dongjoon-hyun commented on code in PR #55422: URL: https://github.com/apache/spark/pull/55422#discussion_r3148723575
########## sql/core/src/main/scala/org/apache/spark/sql/execution/window/SegmentTreeWindowFunctionFrame.scala: ########## @@ -0,0 +1,292 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.window + +import org.apache.spark.TaskContext +import org.apache.spark.memory.TaskMemoryManager +import org.apache.spark.sql.catalyst.InternalRow +import org.apache.spark.sql.catalyst.expressions.{Attribute, Expression, FrameType, MutableProjection, RangeFrame, RowFrame, UnsafeRow} +import org.apache.spark.sql.catalyst.expressions.aggregate.DeclarativeAggregate +import org.apache.spark.sql.execution.ExternalAppendOnlyUnsafeRowArray +import org.apache.spark.sql.execution.metric.SQLMetric +import org.apache.spark.sql.internal.SQLConf + +/** + * Moving-frame window function frame backed by [[WindowSegmentTree]]. Produces + * the same outputs as [[SlidingWindowFunctionFrame]] for RowFrame or + * single-column RangeFrame moving frames whose aggregates are all + * [[DeclarativeAggregate]] with no FILTER/DISTINCT. For partitions below + * `spark.sql.window.segmentTree.minPartitionRows`, delegates to a wrapped + * [[SlidingWindowFunctionFrame]]. Under RANGE, two forward-only cursors + * (`lowerIter` / `upperIter`) advance the bounds in O(n) total; the segtree + * answers `[lowerBound, upperBound)` in O(log n). + * + * @note Not thread-safe. + */ +private[window] final class SegmentTreeWindowFunctionFrame( + target: InternalRow, + processor: AggregateProcessor, + functions: Array[DeclarativeAggregate], + inputSchema: Seq[Attribute], + frameType: FrameType, + lbound: BoundOrdering, + ubound: BoundOrdering, + newMutableProjection: (Seq[Expression], Seq[Attribute]) => MutableProjection, + conf: SQLConf, + maxCachedBlocks: Option[Int], + taskMemoryManager: TaskMemoryManager, + numSegmentTreeFrames: Option[SQLMetric] = None, + numSegmentTreeFallbackFrames: Option[SQLMetric] = None) + extends WindowFunctionFrame with AutoCloseable { + + require(frameType == RowFrame || frameType == RangeFrame, + s"SegmentTreeWindowFunctionFrame supports RowFrame or RangeFrame, got $frameType") + + private[this] var fallback: SlidingWindowFunctionFrame = _ + private[this] var tree: WindowSegmentTree = _ + + /** Allocate a fresh fallback sliding-window frame. Called lazily from + * `prepare()` on the small-partition path. Factored out for testability + * (subclasses can inject a throwing fallback for prepare-failure tests). */ Review Comment: nit. The trailing `*/` looks like a typo. Please place it in a new line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
