SanJSp commented on code in PR #55507:
URL: https://github.com/apache/spark/pull/55507#discussion_r3152982804
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ChangelogTable.scala:
##########
@@ -33,7 +35,13 @@ import org.apache.spark.sql.util.CaseInsensitiveStringMap
*/
case class ChangelogTable(
changelog: Changelog,
- changelogInfo: ChangelogInfo) extends Table with SupportsRead {
+ changelogInfo: ChangelogInfo,
+ resolved: Boolean = false) extends Table with SupportsRead {
Review Comment:
I'm not sure I understand 100%, aren't we already doing this? The problem is
that we want to mark a node as processed to avoid reprocessing it, right? So
[here](https://github.com/apache/spark/blob/697d021f3cfdb48adb4e5efbaa748bdfbc39e179/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveChangelogTable.scala#L71)
and
[here](https://github.com/apache/spark/blob/697d021f3cfdb48adb4e5efbaa748bdfbc39e179/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveChangelogTable.scala#L93)
we create copies of the node and set their field `resolved = true`. Does this
address your concern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
