aokolnychyi commented on code in PR #55576:
URL: https://github.com/apache/spark/pull/55576#discussion_r3157658754
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala:
##########
@@ -350,9 +350,14 @@ case class ReplaceDataExec(
// One of the metrics couldn't be found, also mark numDeletedRows as
not found.
-1L
}
+
+ // SQLMetric.set call is a no-op if value is -1. Override numDeletedRows
value in summary.
Review Comment:
Hm, does it mean the values in UI would differ from the commit info?
Take a closer look at `SQLMetric`. Shall we create them with -1 to indicate
they are invalid? Today, we create them with 0 initial value making them valid
metrics by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
