SanJSp commented on PR #55583: URL: https://github.com/apache/spark/pull/55583#issuecomment-4343835299
@gengliangwang regarding your top level comment: I've removed the dead code. The new `WithUpdateDetectionSuite` actually caught a bug, so well spotted 👍 Claude explanation of bug: > `injectNetChangeComputation` was calling `V2ExpressionUtils.resolveRefs(cl.rowId(), plan)` on the Project(Window(...)) produced by `addRowLevelPostProcessing`, and V2 resolution only works on a bare `DataSourceV2Relation`. Fixed by hoisting `rowId` resolution to the top of apply against the bare relation; the resolved Catalyst attributes flow through any wrapping operators by `ExprId`, so `addNetChangesWindow` doesn't re-resolve. Feel free to give it another check, thanks in advance 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
