Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6627#discussion_r32282547
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/package.scala ---
    @@ -19,15 +19,27 @@ package org.apache.spark.sql.hive
     
     /** Support for interacting with different versions of the 
HiveMetastoreClient */
     package object client {
    -  private[client] abstract class HiveVersion(val fullVersion: String, val 
hasBuiltinsJar: Boolean)
    +  private[client] abstract class HiveVersion(
    +      val fullVersion: String,
    +      val extraDeps: Seq[String] = Nil,
    +      val exclusions: Seq[String] = Nil)
     
       // scalastyle:off
       private[client] object hive {
    -    case object v10 extends HiveVersion("0.10.0", true)
    -    case object v11 extends HiveVersion("0.11.0", false)
    -    case object v12 extends HiveVersion("0.12.0", false)
    -    case object v13 extends HiveVersion("0.13.1", false)
    +    case object v12 extends HiveVersion("0.12.0")
    +    case object v13 extends HiveVersion("0.13.1")
    +
    +    // Hive 0.14 depends on calcite 0.9.2-incubating-SNAPSHOT which does 
not exist in
    +    // maven central anymore, so override those with a version that exists.
    +    //
    +    // org.pentaho:pentaho-aggdesigner-algorithm is also nowhere to be 
found, so exclude
    +    // it explicitly. If it's needed by the metastore client, users will 
have to dig it
    +    // out of somewhere and use configuration to point Spark at the 
correct jars.
    --- End diff --
    
    > maybe we should open a JIRA for Hive though
    
    Not sure how much they'd be able to fix; the dependencies that have 
disappeared are not Hive artifacts, and those Hive versions have already been 
published.
    
    (Or maybe those have never been on maven central and you're supposed to use 
a 3rd-party repo to get them?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to