aokolnychyi commented on code in PR #55278:
URL: https://github.com/apache/spark/pull/55278#discussion_r3164890804
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/streaming/StreamingWrite.java:
##########
@@ -80,6 +80,12 @@ default boolean useCommitCoordinator() {
* The execution engine may call {@code commit} multiple times for the same
epoch in some
* circumstances. To support exactly-once data semantics, implementations
must ensure that
* multiple commits for the same epoch are idempotent.
+ * <p>
+ * Note: this method signals that all data for this write operation has been
successfully written.
+ * It is NOT a transactional commit. When this write is part of a
Review Comment:
This statement can be misleading. It could be a transactional commit from
the connector point view. I think a better message would be to highlight that
if called within Transaction, this should stage changes but not propagate them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
