srielau commented on code in PR #55569:
URL: https://github.com/apache/spark/pull/55569#discussion_r3170209093
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogManager.scala:
##########
@@ -349,4 +350,30 @@ private[sql] object CatalogManager {
compact(JArray(entries.map(parts =>
JArray(parts.map(JString(_)).toList)).toList))
}
+
+ /**
+ * Parse a stored frozen path string from view/function metadata.
+ * Returns None if the payload is malformed.
+ */
+ def deserializePathEntries(storedPathStr: String): Option[Seq[Seq[String]]]
= {
+ import org.json4s.JsonAST.{JArray, JString}
+ import org.json4s.jackson.JsonMethods.parse
+
+ Try(parse(storedPathStr)).toOption match {
+ case Some(JArray(entries)) if entries.nonEmpty =>
+ val converted = entries.foldLeft(Option(Seq.empty[Seq[String]])) {
(acc, entry) =>
+ acc.flatMap { collected =>
+ entry match {
+ case JArray(parts) if parts.nonEmpty =>
+ val strings = parts.collect { case JString(s) => s }
+ if (strings.size == parts.size) Some(collected :+ strings)
+ else None
+ case _ => None
+ }
+ }
+ }
+ converted.filter(_.nonEmpty)
+ case _ => None
Review Comment:
Good call - we revisited this and changed course. In a follow-up commit
(a9ce5a50334), analysis now fails loudly when persisted view/function SQL PATH
metadata is malformed, instead of silently falling back to the live session
PATH. We also added regression tests for both views and SQL functions to lock
this behavior in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
