Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/6673#issuecomment-111319056 I think its reasonable to assume `children` will not change as `TreeNode`s are generally expected to be immutable. I'd add this requirement to the method's scala doc though.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org