sarutak commented on code in PR #55626:
URL: https://github.com/apache/spark/pull/55626#discussion_r3173450747
##########
core/src/main/scala/org/apache/spark/ui/PagedTable.scala:
##########
@@ -219,7 +219,7 @@ private[spark] trait PagedTable[T] {
}
<div class="d-flex justify-content-between align-items-center">
- <div class="d-flex align-items-center">
+ <div class="d-flex align-items-center mb-3">
Review Comment:
Adding `mb-3` only to the **left inner child** breaks symmetry inside the
flex container. The left child gains a 1rem bottom margin, but the right child
(the Jump-to form) does not, so the two children's bottom edges no longer align
under `align-items-center`. Also, since `pageNavigation()` is rendered **both
above and below** the table, the same `mb-3` gets applied to the bottom nav as
well, adding unnecessary spacing there.
Suggested fix: apply the margin to the **outer** flex container instead:
```diff
- <div class="d-flex justify-content-between align-items-center">
- <div class="d-flex align-items-center mb-3">
+ <div class="d-flex justify-content-between align-items-center mb-3">
+ <div class="d-flex align-items-center">
<span class="pe-1">Page: </span>
<ul class="pagination mb-0">
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
