Licht-T commented on PR #55610: URL: https://github.com/apache/spark/pull/55610#issuecomment-4379856779
@MaxGekk @cloud-fan friendly ping when you have a moment - this is a follow-up to [SPARK-33404](https://issues.apache.org/jira/browse/SPARK-33404) that you originally fixed and merged. The slow path you introduced for correctness is preserved as the fallback; the new fast path applies the offset before/after the floorMod and verifies the offset is unchanged at the truncated candidate, so the LMT minute case (and the SPARK-30766 / SPARK-30857 hour/day cases) all still go through the safe path. ~2× speedup on MINUTE/HOUR/DAY locally, which recovers most of the regression flagged in apache/spark#30338. Would appreciate your eyes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
