cloud-fan commented on code in PR #55487:
URL: https://github.com/apache/spark/pull/55487#discussion_r3196787859
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala:
##########
@@ -595,7 +602,7 @@ private[spark] class HiveExternalCatalog(conf: SparkConf,
hadoopConf: Configurat
requireTableExists(db, tableDefinition.identifier.table)
verifyTableProperties(tableDefinition)
- if (tableDefinition.tableType == VIEW) {
+ if (tableDefinition.tableType == VIEW || tableDefinition.tableType ==
METRIC_VIEW) {
Review Comment:
`isViewLike` audit miss (late catch from R6). Same pattern as the round-6
fix on `views.scala:175` -- this inline `tableType == VIEW || tableType ==
METRIC_VIEW` should route through the helper for consistency with sites 277 and
297 in this same file (`createTable`'s schema-fallback branches), which already
use `tableDefinition.isViewLike`. The PR description still claims "All 18
sites... are now routed through these helpers", and
`HiveExternalCatalog.{createTable, alterTable, restoreTableMetadata}` is
explicitly listed there as a touched call site, so the disjunction here is the
inconsistency, not a deliberate skip. I should have flagged this in R6
alongside `views.scala`.
```suggestion
if (tableDefinition.isViewLike) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
