Yicong-Huang commented on code in PR #55726:
URL: https://github.com/apache/spark/pull/55726#discussion_r3205441132


##########
.github/workflows/build_and_test.yml:
##########
@@ -659,6 +729,14 @@ jobs:
           $py -m pip list
           echo ""
         done
+    - name: Download precompiled artifact
+      uses: actions/download-artifact@v6
+      with:
+        name: spark-compile-${{ github.run_id }}
+    - name: Extract precompiled artifact
+      run: |
+        tar -xjf compile-artifact.tar.bz2
+        rm compile-artifact.tar.bz2

Review Comment:
   I was looking for a logic that
   
   ```
   if not SKIP_BUILD:
       sbt compile
   else:
       download_artifact()
    ```
   
   The current versions seems always downloading the artifact, and then check 
if we need to rebuild it?



##########
.github/workflows/build_and_test.yml:
##########
@@ -600,6 +669,7 @@ jobs:
       SKIP_UNIDOC: true
       SKIP_MIMA: true
       SKIP_PACKAGING: true
+      SKIP_BUILD: true

Review Comment:
   maybe `SKIP_SCALA_BUILD`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to