LuciferYang commented on code in PR #55719:
URL: https://github.com/apache/spark/pull/55719#discussion_r3207530784
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala:
##########
@@ -901,61 +901,47 @@ case class UnionExec(children: Seq[SparkPlan]) extends
SparkPlan with CodegenSup
}
}
- // `WidenSetOperationTypes` inserts a `Project(Cast)` above each child whose
- // dataType differs from the widened set type, so on the codegen path
- // `src.dataType == tgt.dataType` holds. The Alias only remaps each child
- // attribute onto the union's output exprId/name/metadata. Mismatched cases
- // are gated upstream by `allChildOutputDataTypesMatch`, so the assert is a
- // defensive guard.
+ // True when the codegen path applies: `outputPartitioning` is
`UnknownPartitioning`,
+ // and `unionedInputRDD` matches the semantics of `sparkContext.union(...)`
in `doExecute`.
+ private def isPlainUnion: Boolean =
outputPartitioning.isInstanceOf[UnknownPartitioning]
Review Comment:
fine for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
