cloud-fan commented on code in PR #55631:
URL: https://github.com/apache/spark/pull/55631#discussion_r3208871092
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/st/stExpressions.scala:
##########
@@ -51,55 +52,69 @@ sealed trait GeospatialInputTypes extends
ImplicitCastInputTypes {
private[sql] object ExpressionDefaults {
val DEFAULT_GEOGRAPHY_SRID: Int = Geography.DEFAULT_SRID
val DEFAULT_GEOMETRY_SRID: Int = Geometry.DEFAULT_SRID
+ val DEFAULT_WKB_ENDIANNESS: String = STUtils.NDR
Review Comment:
**Build break.** `94efab548c` removed `STUtils.NDR`, but this line is the
last reference — `build/sbt catalyst/compile` fails with `value NDR is not a
member of object org.apache.spark.sql.catalyst.util.STUtils`.
Quickest fix is to inline the literal:
```suggestion
val DEFAULT_WKB_ENDIANNESS: String = "NDR"
```
Alternatively, since `DEFAULT_WKB_ENDIANNESS` is only used by the 1-arg
`ST_AsBinary` constructor at line 93, you could drop the constant and inline
`Literal("NDR")` there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
