LuciferYang commented on code in PR #55765:
URL: https://github.com/apache/spark/pull/55765#discussion_r3209958670
##########
sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala:
##########
@@ -268,7 +268,8 @@ trait PlanStabilitySuite extends
DisableAdaptiveExecutionSuite {
// Disable char/varchar read-side handling for better performance.
SQLConf.READ_SIDE_CHAR_PADDING.key -> "false",
SQLConf.LEGACY_NO_CHAR_PADDING_IN_PREDICATE.key -> "true",
- SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "10MB") {
+ SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "10MB",
+ SQLConf.WHOLESTAGE_UNION_CODEGEN_ENABLED.key -> "false") {
Review Comment:
@cloud-fan Which do you think is better: setting the display flag to
`false`, or setting it to `true` and regenerating the golden files? The latter
may provide higher test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
