sarutak commented on PR #55740: URL: https://github.com/apache/spark/pull/55740#issuecomment-4414857941
I'll pin `pyproject-metadata==0.8.1`. > Could you show some evidence to support your fix? Like why the specific version 0.4.1 and 0.9.0? What is the dependency chain? What did not work when we didn't pin the version? ### Regarding beniget scipy uses pythran (`>=0.12.0,<0.13.0`) during its build process. pythran 0.12.x requires `gast<=0.5.3` and `beniget~=0.4.0` as dependencies. - pythran 0.12.2 requirements.txt: https://github.com/serge-sans-paille/pythran/blob/0.12.2/requirements.txt beniget 0.4.2 and later added code to handle Python 3.10 match statement AST nodes (`MatchStar`, `MatchAs`), but these nodes were only implemented in `gast 0.5.4`. Since pythran constrains gast to `<=0.5.3`, the combination of beniget 0.4.2 + gast 0.5.3 results in the following error: ``` AttributeError: module 'gast' has no attribute 'MatchStar' ``` - beniget issue (bug report): https://github.com/serge-sans-paille/beniget/issues/108 - gast 0.5.4 diff where MatchStar was added: https://github.com/serge-sans-paille/gast/compare/0.5.3...0.5.4#diff-44b67094998a7df1e5ce843b5a2faa44950f5896ac9e07ab99d09e2b24c90143R328 Upgrading gast to 0.5.4 or later is not possible because it violates pythran's constraint. Pinning beniget==0.4.1 is the only solution. ### Regarding pyproject-metadata scipy's build system, meson-python, uses pyproject-metadata for metadata processing. pyproject-metadata 0.9.0 introduced breaking changes for PEP 639 support and implicitly requires `packaging>=23.2` (this requirement is not correctly recorded in the package metadata due to a bug). The older version of meson-python used in the Dockerfile environment is not compatible with the API changes in pyproject-metadata 0.9.0, causing the build to fail at the metadata generation stage. Pinning pyproject-metadata==0.8.1 maintains compatibility with the existing meson-python version. - meson-python changelog (notes that 0.18.0 bumped the minimum pyproject-metadata requirement to 0.9.0, and mentions the packaging version requirement bug in 0.9.1): https://mesonbuild.com/meson-python/changelog.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
