zhengruifeng opened a new pull request, #55792:
URL: https://github.com/apache/spark/pull/55792

   ### What changes were proposed in this pull request?
   
   Drop the redundant `QueryTest` term from `extends QueryTest with 
SharedSparkSession` (and its multi-line variants) across 11 test suites in 
`sql/core`. Where `QueryTest` was only imported to satisfy the extends clause, 
the import is also removed.
   
   Affected files:
   - 
`sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2ExtSessionColumnIdSuite.scala`
   - 
`sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2MetadataTableSuite.scala`
   - 
`sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2MetadataViewSuite.scala`
   - 
`sql/core/src/test/scala/org/apache/spark/sql/connector/ResolveChangelogTableNetChangesSuite.scala`
   - 
`sql/core/src/test/scala/org/apache/spark/sql/connector/ResolveChangelogTablePostProcessingSuite.scala`
   - 
`sql/core/src/test/scala/org/apache/spark/sql/connector/ResolveChangelogTableStreamingPostProcessingSuite.scala`
   - 
`sql/core/src/test/scala/org/apache/spark/sql/execution/MetricViewV2CatalogSuite.scala`
   - 
`sql/core/src/test/scala/org/apache/spark/sql/execution/UnionCodegenSuite.scala`
   - 
`sql/core/src/test/scala/org/apache/spark/sql/execution/window/SegmentTreeWindowFunctionSuite.scala`
   - 
`sql/core/src/test/scala/org/apache/spark/sql/execution/window/SegmentTreeWindowMetricsSuite.scala`
   - 
`sql/core/src/test/scala/org/apache/spark/sql/execution/window/WindowSegmentTreeAllowlistSuite.scala`
   
   Suites that reference `QueryTest.<member>` in the body (only 
`SegmentTreeWindowFunctionSuite` via `QueryTest.sameRows`) keep the import.
   
   ### Why are the changes needed?
   
   `SharedSparkSession` already extends `QueryTest`:
   
   ```scala
   trait SharedSparkSession extends QueryTest with SharedSparkSessionBase
   ```
   
   so an explicit `extends QueryTest with SharedSparkSession` on each suite is 
redundant and slightly misleading about the trait hierarchy. Dropping it 
reduces noise and lowers the chance of the pattern being copied into new suites.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Existing tests; `build/sbt sql/Test/compile` passes cleanly on the affected 
sources.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to