haiyangsun-db commented on code in PR #55768:
URL: https://github.com/apache/spark/pull/55768#discussion_r3217546580
##########
udf/worker/core/src/main/scala/org/apache/spark/udf/worker/core/direct/DirectUnixSocketWorkerDispatcher.scala:
##########
@@ -37,7 +37,7 @@ import
org.apache.spark.udf.worker.core.direct.DirectWorkerDispatcher.SOCKET_POL
@Experimental
abstract class DirectUnixSocketWorkerDispatcher(
workerSpec: UDFWorkerSpecification,
- logger: WorkerLogger = WorkerLogger.NoOp)
+ logger: WorkerLogger)
Review Comment:
these are fine changes, but if we can avoid tiny touches in this PR, it will
make it much cleaner to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
