gaogaotiantian commented on PR #55677: URL: https://github.com/apache/spark/pull/55677#issuecomment-4434098432
> I think we should note this as a warning somehow. for example post a comment. because some reviewers/committers expect a green CI before review: If a PR's CI is failing, they may not spend time to review it. We don't do any PR related comments at this point so that's a whole new infra we need to discuss. However, I don't think it should be a common pattern to break connect client CI. The reason we add this CI is to prevent such cases happening. I think the committer should be explicitly pinged and informed that the PR will break the backward compatibility in a way and the old branches will be patched ASAP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
