uros-db commented on code in PR #54950:
URL: https://github.com/apache/spark/pull/54950#discussion_r3241931251
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala:
##########
@@ -217,6 +217,15 @@ abstract class TypeCoercionSuiteBase extends AnalysisTest {
shouldNotCast(checkedType, IntegralType)
}
+ test("SPARK-56152: implicit type cast - TimeType") {
+ val checkedType = TimeType()
+ checkTypeCasting(checkedType, castableTypes = Seq(checkedType, StringType)
++ datetimeTypes)
+ shouldCast(checkedType, AnyTimeType, AnyTimeType.defaultConcreteType)
Review Comment:
Updated to actually exercise the new StringType → AnyTimeType branch. Same
addition mirrored in AnsiTypeCoercionSuite.scala:91. These two new assertions
go through the modified implicitCast branch since the source is StringType.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
