yaooqinn commented on code in PR #55861:
URL: https://github.com/apache/spark/pull/55861#discussion_r3246156860
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/ExecutionPage.scala:
##########
@@ -46,53 +46,48 @@ class ExecutionPage(parent: SQLTab) extends
WebUIPage("execution") with Logging
val executionId = parameterExecutionId.toLong
val content = sqlStore.execution(executionId).map { executionUIData =>
- val currentTime = System.currentTimeMillis()
- val duration =
executionUIData.completionTime.map(_.getTime()).getOrElse(currentTime) -
- executionUIData.submissionTime
+ val isSubExec = executionUIData.rootExecutionId != executionId
+ val subExecutions = if (groupSubExecutionEnabled) {
+ sqlStore.executionsList()
+ .filter(e => e.rootExecutionId == executionId && e.executionId !=
executionId)
+ } else {
+ Seq.empty
+ }
val summary =
- <div>
- <ul class="list-unstyled">
- <li>
- <strong>Submitted Time:
</strong>{UIUtils.formatDate(executionUIData.submissionTime)}
- </li>
- <li>
- <strong>Duration: </strong>{UIUtils.formatDuration(duration)}
- </li>
- {
- Option(executionUIData.queryId).map { qId =>
- <li>
- <strong>Query ID: </strong>{qId}
- </li>
- }.getOrElse(Seq.empty)
- }
- {
- if (executionUIData.rootExecutionId != executionId) {
- <li>
- <strong>Parent Execution: </strong>
- <a href={"?id=" + executionUIData.rootExecutionId}>
- {executionUIData.rootExecutionId}
- </a>
- </li>
- }
- }
- {
- if (groupSubExecutionEnabled) {
- val subExecutions = sqlStore.executionsList()
- .filter(e => e.rootExecutionId == executionId &&
e.executionId != executionId)
- if (subExecutions.nonEmpty) {
- <li>
- <strong>Sub Executions: </strong>
- {
- subExecutions.map { e =>
- <a href={"?id=" +
e.executionId}>{e.executionId}</a><span> </span>
+ <div class="mb-3">
+ <table id="sql-execution-table" class="table table-striped compact
cell-border"
Review Comment:
Done in 7ebca11 — added a comment above the `summary` block noting headers
are generated by DataTables from column defs in `sql-execution-detail.js`, with
a SPARK-56259 reference to flag the double-render trap. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
