szehon-ho commented on code in PR #55887:
URL: https://github.com/apache/spark/pull/55887#discussion_r3247468397
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/PushDownUtils.scala:
##########
@@ -139,12 +141,16 @@ object PushDownUtils extends Logging {
* the first pass are used to derive PartitionPredicates in the second pass,
avoiding duplicate
* pushdown.
*
+ * The partition-predicate schema is passed by-name so callers that cannot
supply one (no
+ * partition transforms available) or whose scan does not opt into iterative
pushdown pay no
+ * derivation cost.
+ *
* @return true if any filters were pushed to the data source
*/
def pushRuntimeFilters(
scan: Scan,
runtimeFilters: Seq[Expression],
- table: Table,
+ partitionPredicateSchema: => Option[Seq[PartitionPredicateField]],
Review Comment:
agree to add a helper taking Table for convenience
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
