LuciferYang commented on code in PR #55853: URL: https://github.com/apache/spark/pull/55853#discussion_r3248125118
########## sql/core/benchmarks/ParquetVectorUpdaterBenchmark-jdk21-results.txt: ########## @@ -7,13 +7,13 @@ AMD EPYC 7763 64-Core Processor Identity Updaters: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ BooleanUpdater 0 0 0 17004.4 0.1 1.0X -ByteUpdater (INT32 -> Byte) 0 0 0 3758.6 0.3 0.2X -ShortUpdater (INT32 -> Short) 1 1 0 1678.4 0.6 0.1X -IntegerUpdater 0 0 0 10276.1 0.1 0.6X Review Comment: Agree — pre-existing %5.0f rounding in Benchmark.scala. Maybe we can uniformly switch it to %5.1f or %5.2f to make non-zero time values visible for lightweight cases in all Spark benchmarks? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
