cloud-fan commented on code in PR #55941: URL: https://github.com/apache/spark/pull/55941#discussion_r3258881165
########## sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ArrayUtils.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.expressions; + +import org.apache.spark.QueryContext; +import org.apache.spark.sql.errors.QueryExecutionErrors; + +/** + * Static helpers for array-related expressions invoked from + * {@code doGenCode} and {@code eval} paths. + * + * Currently provides the ANSI-mode index validation for + * {@link ElementAt} on {@code ArrayType}: a single call replaces ~12 lines + * of inline length / zero / sign-normalization codegen with a return of + * the normalized array position (0-based). + */ +public final class ArrayUtils { Review Comment: The stack uses per-operation naming (`CastUtils`, `ArithmeticUtils`, `DateTimeConstructorUtils`). `ArrayUtils` is broader than its single `element_at`-specific helper, and there's already an `ArrayExpressionUtils.java` in the same package that serves array-expression helpers. Risk: future readers won't know which utility class to look in, and `ArrayUtils` becomes a magnet for unrelated array helpers. Consider renaming to `ElementAtUtils` (matches `DateTimeConstructorUtils`-style per-operation naming), or folding `elementAtIndexExact` into the existing `ArrayExpressionUtils`. WDYT? ########## sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ArrayUtils.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.expressions; + +import org.apache.spark.QueryContext; +import org.apache.spark.sql.errors.QueryExecutionErrors; + +/** + * Static helpers for array-related expressions invoked from + * {@code doGenCode} and {@code eval} paths. + * + * Currently provides the ANSI-mode index validation for + * {@link ElementAt} on {@code ArrayType}: a single call replaces ~12 lines + * of inline length / zero / sign-normalization codegen with a return of + * the normalized array position (0-based). Review Comment: The `a single call replaces ~12 lines ...` clause describes the PR's effect rather than the helper's contract — once merged, the original 12-line inline form isn't visible to future readers. Peer `CastUtils.java` doesn't include similar line-count claims. ```suggestion * {@link ElementAt} on {@code ArrayType}. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
