fallintoplace commented on code in PR #55964:
URL: https://github.com/apache/spark/pull/55964#discussion_r3264487763
##########
python/pyspark/sql/tests/test_functions.py:
##########
@@ -948,6 +948,14 @@ def test_try_make_interval(self):
actual = df.select(F.isnull(F.try_make_interval("num")))
assertDataFrameEqual([Row(True)], actual)
+ def test_try_mod_function(self):
+ df = self.spark.createDataFrame([(6000, 15), (3, 2), (1234, 0)], ["a",
"b"])
Review Comment:
Good point @zhengruifeng, thanks. I missed that the main `try_mod` behavior
is already covered by the doctest. The only additional coverage here is the
`Column` + literal path, which is probably too small to justify a separate
test. I will close this PR unless you think explicit coverage in
`test_functions.py` is still useful for SPARK-54476.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
