szehon-ho commented on code in PR #55967:
URL: https://github.com/apache/spark/pull/55967#discussion_r3269844361
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/MergeRowsExecBenchmark.scala:
##########
@@ -101,6 +105,33 @@ object MergeRowsExecBenchmark extends SqlBasedBenchmark
with ClassicConversions
Dataset.ofRows(spark, mergeRows)
}
+ /**
+ * Like [[codegenBenchmark]], but with JIT warm-up and a longer timed window
so interpreted
+ * (whole-stage off) results are more stable when comparing metric caching
changes.
+ */
+ private def mergeRowsCodegenBenchmark(name: String, cardinality: Long)(f: =>
Unit): Unit = {
Review Comment:
yea, it is actually right. i had to modify the benchmark to increase the
warmup, in order to get more consistent numbers. But I did run these two cases
on the same new benchmark on this pr
- spark code of origin/master
- spark code of this pr (with cached metrics)
That being said, let me see if i need to do the benchmark changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
