longvu-db commented on PR #55577: URL: https://github.com/apache/spark/pull/55577#issuecomment-4499514764
## Code Review (automated) **Files Changed**: 1 (+287/-0) **File**: `sql/connect/server/src/test/scala/org/apache/spark/sql/connect/DataSourceV2CacheConnectSuite.scala` | Severity | Count | |----------|-------| | P0 (Critical) | **0** | | P1 (Important) | **0** | | P2 (Minor) | **0** | ### Review Notes - `withSession` / `withCachedTable` lifecycle is correct (`finally` cleanup runs while session is alive) - `externalAppend` correctly uses `loadTable(ident, writePrivileges)` to bypass `copyOnLoad` - `BufferedRows(Seq.empty, schema)` is correct for unpartitioned tables - `IF EXISTS` in cleanup handles S5 drop/recreate edge case - `getServerSession` for `assertCached` is necessary (internal plan detail not exposed via Connect) - `afterEach` ordering (`invalidateAllSessions`) runs after test body **Recommendation: APPROVE** - No bugs, security issues, or breaking changes found. _Review generated with Claude Code._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
