yaooqinn commented on code in PR #55982:
URL: https://github.com/apache/spark/pull/55982#discussion_r3278819271
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeRandSuite.scala:
##########
@@ -173,4 +176,59 @@ class OptimizeRandSuite extends PlanTest {
}
}
+ test("Support arithmetic expressions with rand in optimization") {
Review Comment:
The 9 new tests use `assert(actualN != null)` only. `Optimize.execute`
returns `LogicalPlan` and never null, so these asserts pass regardless of
whether the new optimization fires — the rule could be a no-op and the suite
would still go green. Sibling tests in this same file (lines 65, 82, 95, 110,
123, 137, 147, 163, 175) all use `comparePlans(actual, correctAnswer)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
