sven-weber-db commented on code in PR #55716:
URL: https://github.com/apache/spark/pull/55716#discussion_r3282049393
##########
python/pyspark/worker_util.py:
##########
@@ -65,11 +67,11 @@ def add_path(path: str) -> bool:
return False
-def read_command(serializer: FramedSerializer, file: Union[IO, bytes]) -> Any:
+def read_command(serializer: FramedSerializer, file: Union[IO, memoryview]) ->
Any:
Review Comment:
>Have you tried the asv benchmark? It actually simulates the message to
python workers. Is it still working?
Yes! Please see the benchmarking results in the PR description. I re-ran all
current PySpark benchmarks before and after this change. Both runs succeeded,
and there was no performance regression found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
