dongjoon-hyun commented on PR #56003: URL: https://github.com/apache/spark/pull/56003#issuecomment-4510077376
> @dongjoon-hyun I intentionally didn't add `_TEST_` to `SPARK_VERSIONS_SUITE_IVY_SETTINGS` to be consistent with `SPARK_VERSIONS_SUITE_IVY_PATH`. I think we should leave `SPARK_VERSIONS_SUITE_IVY_PATH` as is but do you think it better to add `_TEST_` to `SPARK_VERSIONS_SUITE_IVY_SETTINGS`? I believe we should not make another mistake like `SPARK_VERSIONS_SUITE_IVY_PATH` which is a clear mistake 10 years ago (2016), @sarutak . We don't need to make mistakes consistently, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
