gengliangwang commented on PR #55937: URL: https://github.com/apache/spark/pull/55937#issuecomment-4511518623
Audited this PR for the same lessons surfaced by @viirya and @cloud-fan on #55938 (and applied to #55934 / #55939): 1. **Are the helpers redundant with an existing Scala API?** No — there's no existing Scala object that wraps `StringUtils.isTrueString` / `isFalseString` with the ANSI `invalidInputSyntaxForBooleanError` throw. The helper is net-new. 2. **Are the eval-path additions redundant?** No — master ANSI string -> boolean was a 7-line inline block. The new ANSI branch is a one-line helper call; the non-ANSI branch is simplified by moving the `ansiEnabled` check out into the case clause. So no changes needed on this PR for that review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
