nnguyen168 commented on PR #55466:
URL: https://github.com/apache/spark/pull/55466#issuecomment-4524871331
Hi @yadavay-amzn, thanks for this fix! The root cause analysis is clear and
the fix looks correct to me.
I reviewed the change and have a few observations:
1. The `hasPrecedingNonCommentString` flag mirrors the existing logic in
`StringUtils.splitSemiColonWithIndex` — nice consistency.
2. The test case covers the exact reproduction scenario.
One minor question: should we also add a test case for nested block
comments like `SELECT 1; SELECT 2 /* outer /* inner */ */` to ensure the fix
handles edge cases?
Happy to help test or verify if needed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
