shrirangmhalgi commented on PR #56051: URL: https://github.com/apache/spark/pull/56051#issuecomment-4526784871
Thanks @gaogaotiantian for the review. That makes sense - added `# pragma: no cover` to the assertion. The intent of the change is to move the guard from inside a dead else branch to function level, so it's structurally clearer as a safety net for future type additions. Could you please review the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
