HeartSaVioR commented on code in PR #56057:
URL: https://github.com/apache/spark/pull/56057#discussion_r3294010330
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala:
##########
@@ -2002,6 +2008,7 @@ case class Distinct(child: LogicalPlan) extends UnaryNode
{
final override val nodePatterns: Seq[TreePattern] = Seq(DISTINCT_LIKE)
override protected def withNewChildInternal(newChild: LogicalPlan): Distinct
=
copy(child = newChild)
+ override def isStateful: Boolean = child.isStreaming
Review Comment:
Agreed - it's good to have a comment as it's not directly converted in
physical planning but rather go through operator rewrite. Let's have a code
comment to briefly explain it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
