Richard-Durkee commented on PR #56025: URL: https://github.com/apache/spark/pull/56025#issuecomment-4529296654
> Hi @Richard-Durkee, thanks for adding this compatibility feature! The change is clean and well-tested. > > I noticed this aligns with MySQL/Trino/BigQuery behavior. A couple of thoughts: > > 1. The auxiliary constructor approach is elegant — keeps backward compatibility. > 2. Golden file tests are comprehensive. > > Minor: Have you considered adding a note to the SQL function documentation about this two-argument form? > > Let me know if I can help with anything! Thanks! The `@ExpressionDescription` annotation was updated with the two-argument form, my understanding is that this auto-generates the SQL function docs. Please leave a comment on the Jira issue if you believe this feature would be useful! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
