Github user ehnalis commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6671#discussion_r32308207
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
    @@ -460,7 +460,9 @@ private[deploy] class SparkSubmitArguments(args: 
Seq[String], env: Map[String, S
             |                              on one of the worker machines 
inside the cluster ("cluster")
             |                              (Default: client).
             |  --class CLASS_NAME          Your application's main class (for 
Java / Scala apps).
    -        |  --name NAME                 A name of your application.
    +        |  --name NAME                 A name of your application. In 
yarn-cluster mode the name
    --- End diff --
    
    @vanzin Okay. The problem is with `yarn-client` mode. When you have an 
application name with `SparkContext.setAppName` and you use the `spark-submit` 
shell script with `--name` as well, `SparkContext.setAppName` will be used. 
`--name` should have precedence then. Would it be okay, if we would change the 
code to use `--name` always - if supplied - and to encourage users at 
`SparkContext.setAppName` to use `--name` if possible?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to