cloud-fan commented on code in PR #56095:
URL: https://github.com/apache/spark/pull/56095#discussion_r3300808117
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala:
##########
@@ -329,7 +331,7 @@ abstract class SparkPlan extends QueryPlan[SparkPlan] with
Logging with Serializ
* @note `prepare` method has already walked down the tree, so the
implementation doesn't have
* to call children's `prepare` methods.
*
- * This will only be called once, protected by `this`.
+ * This will only be called once, protected by [[subqueryLock]].
Review Comment:
The new wording references `subqueryLock`, which is `private` — subclasses
overriding `doPrepare()` can't see it, so the link points at a name future
readers won't be able to navigate to. The pre-PR `protected by 'this'` was
informative because `this` was in scope; pointing at a private name is a step
back.
```suggestion
* This will only be called once, protected by an internal lock.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
