viirya commented on PR #56102: URL: https://github.com/apache/spark/pull/56102#issuecomment-4540055016
Thanks for the review @dongjoon-hyun! Force-pushed `a13783190d4` addressing all four review comments: - Removed the dependency on `java.util.NoSuchElementException`; introduced typed `BranchNotFoundException` and `InvalidFastForwardException` alongside `BranchAlreadyExistsException`, following the existing DSv2 `NoSuch*Exception` naming pattern. - Updated `InMemoryTable.fastForward` and `DropBranchExec` to throw the new typed exceptions. - Fixed the two scalastyle errors (`toLowerCase` without `Locale.ROOT` and `util.Collections.emptySet()`) in `SupportsBranchingSuite`. - Updated the suite to intercept the new typed exceptions. `sql/Test/scalastyle` is clean locally and the full `SupportsBranchingSuite` still passes. PTAL when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
