Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/6725#discussion_r32314542
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -254,3 +254,52 @@ case class Pow(left: Expression, right: Expression)
"""
}
}
+
+object Logarithm {
+ def apply(child: Expression): Expression = new Log(child)
+}
+
+case class Logarithm(left: Expression, right: Expression)
+ extends BinaryMathExpression((c1, c2) => math.log(c2) / math.log(c1),
"LOG") {
--- End diff --
If we need to override the `eval()`, probably it's better to inherit from
`BinaryArithmetic`, not `BinaryMathExpression`, then we needn't to pass the
additional function object for its parent class.
Or can we remove the `eval()` from this class?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
