MaxGekk commented on code in PR #49773:
URL: https://github.com/apache/spark/pull/49773#discussion_r3311127479
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/UnsafeRowUtils.scala:
##########
@@ -17,11 +17,38 @@
package org.apache.spark.sql.catalyst.util
+import java.nio.ByteOrder.{nativeOrder, BIG_ENDIAN}
+
import org.apache.spark.sql.catalyst.expressions.UnsafeRow
import org.apache.spark.sql.types._
object UnsafeRowUtils {
+ sealed trait PaddingProvider {
+ def getPadding(row: UnsafeRow, index: Int, bitShift: Int): Long
+ def getPaddingBoolean(row: UnsafeRow, index: Int): Long
+ }
+
+ object PaddingProviderLE extends PaddingProvider {
+ override def getPadding(
+ row: UnsafeRow, index: Int, bitShift: Int): Long = row.getLong(index) >>
bitShift
+ override def getPaddingBoolean(
+ row: UnsafeRow, index: Int): Long = row.getLong(index) >> 1
+ }
+
+ object PaddingProviderBE extends PaddingProvider {
+ override def getPadding(
+ row: UnsafeRow, index: Int, bitShift: Int): Long = row.getLong(index) <<
bitShift
+ override def getPaddingBoolean(
+ row: UnsafeRow, index: Int): Long = row.getLong(index) &
0xFEFFFFFFFFFFFFFFL
+ }
+
+ private final val padder: PaddingProvider = if
(nativeOrder().equals(BIG_ENDIAN)) {
Review Comment:
Isn't **final** redundant on a val? Also cosmetic:
```suggestion
private final val padder: PaddingProvider = if (nativeOrder() ==
BIG_ENDIAN)) {
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/UnsafeRowUtils.scala:
##########
@@ -17,11 +17,38 @@
package org.apache.spark.sql.catalyst.util
+import java.nio.ByteOrder.{nativeOrder, BIG_ENDIAN}
+
import org.apache.spark.sql.catalyst.expressions.UnsafeRow
import org.apache.spark.sql.types._
object UnsafeRowUtils {
+ sealed trait PaddingProvider {
Review Comment:
Could you make the added trait/objects private (or private[util] if you want
them reachable from the suite). They're an internal dispatch detail of one
private method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
