AnishMahto commented on code in PR #56160:
URL: https://github.com/apache/spark/pull/56160#discussion_r3314975559
##########
sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/graph/FlowExecution.scala:
##########
@@ -331,6 +331,33 @@ object AutoCdcAuxiliaryTable {
* serves.
*/
val scdTypePropertyKey: String =
s"${PipelinesTableProperties.pipelinesPrefix}autocdc.scd_type"
+
+ /**
+ * Table property recording the auxiliary table's AutoCDC key column names
as a JSON string
+ * array (e.g. `["id","region"]`). Written once when the auxiliary table is
created and is
+ * considered immutable; full-refresh is the only way to change it.
+ */
+ val keyColumnNamesProperty: String =
+ PipelinesTableProperties.pipelinesPrefix + "autoCdc.keyColumnNames"
Review Comment:
Good catch. Following Spark SQL conf convention, I switched `scd_type` to
camel case, and kept `keyColumnNames` as-is.
If this change lands 4.2 there's no issue, if we miss 4.2 then I'll
standardize in the opposite direction (adopting snake case to match the already
merged `scd_type`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
