viirya opened a new pull request, #56171:
URL: https://github.com/apache/spark/pull/56171

   ### What changes were proposed in this pull request?
   
   Rename the `wide_values` scenario key to `wide_cols` in three mixins of 
`python/benchmarks/bench_eval_type.py`:
   
   - `_CogroupedMapArrowBenchMixin`
   - `_CogroupedMapPandasBenchMixin`
   - `_GroupedMapArrowBenchMixin`
   
   ### Why are the changes needed?
   
   The umbrella SPARK-55724 introduced \"wide-column\" scenarios under two 
different keys: `wide_values` (SPARK-55947 grouped map Arrow, SPARK-56381 
cogrouped map Arrow, SPARK-56629 cogrouped map pandas) and `wide_cols` 
(SPARK-56085 grouped agg, SPARK-56120 window agg Arrow, SPARK-56562 grouped agg 
pandas, SPARK-56658 window agg pandas). All seven describe the same shape: few 
rows per group, many columns.
   
   The drift makes the ASV summary harder to read across eval types and adds 
friction when wiring shared helpers across siblings. `wide_cols` is the more 
descriptive name (the scenario varies the column count, not the value 
semantics) and is already the majority spelling.
   
   Since these benchmarks have no nightly CI consumer yet, renaming now costs 
nothing in ASV history continuity; deferring the rename only makes the eventual 
cleanup costlier.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No. Test-only change in the benchmark module.
   
   ### How was this patch tested?
   
   - `grep` confirmed no remaining `wide_values` references in the file.
   - Ran `setup` + `time_worker` on `wide_cols` for the three renamed 
`*TimeBench` classes (`CogroupedMapArrowUDFTimeBench`, 
`CogroupedMapPandasUDFTimeBench`, `GroupedMapArrowUDFTimeBench`); all passed.
   - Ran the same on the four pre-existing `wide_cols` `*TimeBench` classes 
(`GroupedAggArrowUDFTimeBench`, `GroupedAggPandasUDFTimeBench`, 
`WindowAggArrowUDFTimeBench`, `WindowAggPandasUDFTimeBench`) to confirm no 
regression.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Yes. Generated-by: Claude Code (claude-opus-4-7)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to