gengliangwang opened a new pull request, #56222: URL: https://github.com/apache/spark/pull/56222
### What changes were proposed in this pull request? Add `ExpressionImplUtils.crc32(byte[] bytes)` and route `Crc32`'s eval and codegen paths through it. `Crc32.doGenCode` previously emitted a 3-line allocate / `update` / `getValue` sequence inline; it now emits a single `ExpressionImplUtils.crc32(...)` call, and the eval path calls the same helper. This is a plain (non-ANSI, non-try/catch) type-independent block, in line with the broadened goal of SPARK-56908 to move fixed generated-Java logic into static Java helpers. ### Why are the changes needed? Part of SPARK-56908 (umbrella). Collapsing the inline CRC32 sequence to one call shrinks the generated Java for every stage that computes `crc32`, helping with the JVM 64KB method / constant-pool limits, Janino compile time, and JIT work. ### Does this PR introduce _any_ user-facing change? No. The compiled behavior is identical; only the emitted Java source text changes. ### How was this patch tested? ``` build/sbt "catalyst/testOnly *HashExpressionsSuite" ``` 40/40 pass, including `crc32` (exercised both with and without whole-stage codegen). ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
