shrirangmhalgi commented on PR #56145: URL: https://github.com/apache/spark/pull/56145#issuecomment-4583578611
One question about the `SparkSqlParser` change: when `contextHasParams` is true, you pass `None` as sqlText to `withErrorHandling`, which means parse errors in parameterized scripts won't include the SQL text in error messages. Is this intentional to avoid showing the substituted (expanded) text with mismatched positions? If so, could the original (pre-substitution) text be passed instead, since `PositionMapper` could map error positions back? Or would that require more plumbing than it's worth for this fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
