yadavay-amzn commented on PR #56101: URL: https://github.com/apache/spark/pull/56101#issuecomment-4598582689
@cloud-fan Thank you for the detailed review. All items addressed: **Blocking (3/3):** 1. Ranking: `Cast(_, DoubleType)` → `TypeUtils.getInterpretedOrdering(rankExpr.dataType)`. Also added `.copy()` on ranking rows to prevent buffer corruption for variable-length types. 2. Output nullability: matches logical `NearestByJoin.output` (both sides nullable). 3. Benchmark: converted to `SqlBasedBenchmark` object. **Non-blocking (4/4):** 1. Extends `BaseJoinExec` with `condition=None`, `leftKeys/rightKeys=Seq.empty`, overrides `simpleStringWithNodeId`. 2. Shared `NearestByJoin.canBroadcastRight(j, conf)` with `sizeInBytes >= 0` guard. 3. Boxed tuples → `HeapEntry` case class (unboxed Int). 4. Added tests: NaN-under-similarity, null-in-non-ranking-column, DateType, Long past 2^53, Decimal, StringType. **Nits (3/3):** All fixed. 25 tests total, all passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
