hvanhovell commented on code in PR #55683: URL: https://github.com/apache/spark/pull/55683#discussion_r3342241324
########## udf/worker/core/src/main/scala/org/apache/spark/udf/worker/core/WorkerSession.scala: ########## @@ -58,15 +58,23 @@ import org.apache.spark.udf.worker.Init * See [[cancel]] for the full contract. * * The lifecycle is enforced here: [[init]] and [[process]] are `final` - * and delegate to [[doInit]] / [[doProcess]] after AtomicBoolean guards. - * Subclasses implement the protocol-specific work and do not re-check - * the contract. + * and route through [[doInit]] / [[doProcess]] after AtomicBoolean Review Comment: Not sure if I care about atomic booleans. I care about the semantics. Please emphasize this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
