Github user massie commented on the pull request:
https://github.com/apache/spark/pull/6423#issuecomment-111593360
@kayousterhout I just pushed an update which checks that
`BufferReleasingInputStream` is not just releasing memory but also closing the
underlying delegate `InputStream`.
I also put a note in the `HashShuffleReader` which explains that
`asKeyValueIterator` wraps the key/value iterator inside a `NextIterator` which
ensures that `close()` is called on the underlying `InputStream`. I verified
that `NextIteratorSuite` has tests to ensure that `close()` is called.
Do these changes address your concerns or have I missed something? Let me
know if you'd like additional changes made.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
