davidm-db opened a new pull request, #56667: URL: https://github.com/apache/spark/pull/56667
### What changes were proposed in this pull request? Removes three now-dead `TimeType` fallback arms in the Parquet code -- in `ParquetSchemaConverter.convertFieldDefault`, `ParquetWriteSupport.makeWriterDefault`, and `ParquetRowConverter.newConverterDefault`. Since `ParquetTypeOps.apply` returns `Some(TimeTypeParquetOps)` for `TimeType` unconditionally, the framework-first dispatch always intercepts `TimeType`, so these `...Default` arms are unreachable and `TimeTypeParquetOps` is the single source of truth. The reachable paths (the read-path `TIME` annotation -> `TimeType` mapping and the vectorized reader) are left untouched. See [SPARK-57582](https://issues.apache.org/jira/browse/SPARK-57582). ### Why are the changes needed? Dead code: redundant with `TimeTypeParquetOps` and a maintenance hazard -- e.g. #56622 had to keep the removed arms' `MICROS`/`NANOS` logic in sync with the live op. ### Does this PR introduce _any_ user-facing change? No. Pure dead-code removal; the framework path is the one that already executes. ### How was this patch tested? `sql/core` compiles cleanly and `TimeTypeParquetOpsSuite` passes locally; the broader Parquet `TimeType` suites run in CI. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.8 (claude-opus-4-8) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
