Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6773#discussion_r32372512
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -108,9 +108,12 @@ case class Exchange(
// both cases, we must copy.
true
}
- } else {
+ } else if (shuffleManager.isInstanceOf[HashShuffleManager]) {
--- End diff --
This check isn't fixing any bugs / correctness issues _yet_, but I thought
that it might guard against hard-to-find future bugs if someone defines a new
shuffle manager without updating the logic here. It's extremely unlikely that
anyone would do this, but in light of proposals like ParquetShuffleManager it
seemed like the safest option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
