XdithyX commented on PR #56486:
URL: https://github.com/apache/spark/pull/56486#issuecomment-4860036120

   Hi @cloud-fan 
   I removed the new public API pieces and kept the change focused on the 
existing stateful ScanBuilder flow.
   
   The updated patch:
   - drops JoinPushDownInfo / JoinSideInfo / TableSample / PushedOperator and 
the 6-arg pushDownJoin overload
   - keeps the guard removal in V2ScanRelationPushDown
   - keeps JDBC preserving its own stored tableSampleClause when building 
pushed join-side subqueries
   - documents the existing pushDownJoin contract: if a scan builder holds 
previously pushed state such as a table sample and cannot preserve it across 
join pushdown, it must return false
   
   I've updated the PR description as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to